Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Disable codecov #20173

Merged
merged 2 commits into from
Apr 15, 2021
Merged

Disable codecov #20173

merged 2 commits into from
Apr 15, 2021

Conversation

josephevans
Copy link
Contributor

Description

Disable use of codecov in master branch.

@mxnet-bot
Copy link

Hey @josephevans , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-gpu, unix-cpu, centos-cpu, clang, edge, sanity, website, windows-cpu, windows-gpu, centos-gpu, miscellaneous]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@marcoabreu
Copy link
Contributor

Could you elaborate? The vulerability already has been patched.

@szha
Copy link
Member

szha commented Apr 15, 2021

@marcoabreu safer to have AWS security review first before adding it back. For now we won't support codecov on the CI until it's deemed safe.

@szha szha merged commit 6b0ec84 into apache:master Apr 15, 2021
@szha
Copy link
Member

szha commented Apr 15, 2021

The follow up step is to add the rotated credentials to make the CI work again, have the security team in AWS review whether codecov is acceptably safe on our system, and then add it back afterwards.

@marcoabreu
Copy link
Contributor

Okay, works for me . Thanks!

Btw, with the cached version of codecov which we used before, this would have been averted.

@szha
Copy link
Member

szha commented Apr 15, 2021

Indeed.

@leezu
Copy link
Contributor

leezu commented Apr 16, 2021

Are you referring to the code from 3 years ago?

https://github.com/apache/incubator-mxnet/blob/ecadeac9a2fbacc7e5b726783ecac6bdc7558b1e/ci/Jenkinsfile_utils.groovy#L126-L128

I'm not sure that would have prevented the problem as it's only fallback :)

@marcoabreu
Copy link
Contributor

Oh I thought it was the other way around. Nevermind then

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants